add error handling for worker threads

gravityvi · Jul 21, 2023 · 8eb4bd4 · 8eb4bd4
1 parent 3cf114f
commit 8eb4bd4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/lib/runner/concurrency/index.js b/lib/runner/concurrency/index.js
@@ -185,7 +185,7 @@ class Concurrency extends EventEmitter {
       if (this.isSafariEnvPresent) {
         extraArgs.push('--serial');
       }
-      let childProcess = this.createChildProcess(environment, args, extraArgs, index);
+      const childProcess = this.createChildProcess(environment, args, extraArgs, index);
 
       return this.runChildProcess(childProcess, environment + ' environment', availColors, 'envs');
     }));
@@ -296,7 +296,12 @@ class Concurrency extends EventEmitter {
     });
 
 
-    return Promise.all(workerPool.tasks);
+    return new Promise((resolve, reject) => {
+      Promise.allSettled(workerPool.tasks)
+        .then(values => {
+          values.some(({status}) =>  status === 'rejected') ? reject() : resolve();
+        }); 
+    });
   }
 
 

diff --git a/lib/runner/concurrency/worker-task.js b/lib/runner/concurrency/worker-task.js
@@ -94,6 +94,7 @@ class WorkerTask extends EventEmitter {
     port2.unref();
 
     return this.piscina.run({argv: this.argv, port1}, {transferList: [port1]})
+      .catch(err => err)
       .then(failures => {
         if (this.settings.disable_output_boxes){
           // eslint-disable-next-line no-console
@@ -102,6 +103,11 @@ class WorkerTask extends EventEmitter {
           // eslint-disable-next-line no-console
           console.log(boxen(this.task_output.join('\n'), {title: `────────────────── ${failures ? symbols.fail : symbols.ok} ${this.task_label}`, padding: 1, borderColor: 'cyan'}));
         }
+
+        //throw error to mark exit-code of the process
+        if (failures) {
+          throw new Error();
+        }
       });
   }
 }