This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
fix: make Jettys threads use gravitee context class loader #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytvnr
approved these changes
Nov 3, 2021
Jetty version has been upgraded in this commit : gravitee-io/gravitee-bom@6eb8566 It introduced mutliple regressions in APIM. Since 9.4.37, Jettys threads classloaders have been refactored to fix a leak (see jetty/jetty.project#5894). After this fix, threads classpath is override with local classpath, so it does not contain gravitee context class loader nomore (see https://github.com/eclipse/jetty.project/pull/5894/files#diff-6f0181889aa765771dd358e58fc07e2a7d7bfa44c451359e34e3eea574a5a79cR696). Created a JettyQueuedThreadPool, to override Jetty's default QueuedThreadPool and give the gravitee context class loader to created threads.
marcambier
force-pushed
the
fix/fixJettyClassPath
branch
from
05d4c2b
to
6edce3b
Compare
|
[Gravitee.io APIM - UI Portal] Kudos, SonarCloud Quality Gate passed!
|
|
[Gravitee.io APIM - UI Console] Kudos, SonarCloud Quality Gate passed!
|
|
Gravitee.io Automatic Deployment Congrats, all the CI steps were 🟢 . The Bot was able to deploy the build of this PR, so you can now try it directly here! 🚀 Notes: The deployed app is linked to the management API of the Element Zero team's environment. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gravitee-io/issues#6290
gravitee-io/issues#6494
Jetty version has been upgraded in this commit : gravitee-io/gravitee-bom@6eb8566
It introduced mutliple regressions in APIM.
Since 9.4.37, Jettys threads classloaders have been refactored to fix a leak (see jetty/jetty.project#5894).
After this fix, threads classpath is override with local classpath, so it does not contain gravitee context class loader nomore (see https://github.com/eclipse/jetty.project/pull/5894/files#diff-6f0181889aa765771dd358e58fc07e2a7d7bfa44c451359e34e3eea574a5a79cR696).
Created a JettyQueuedThreadPool, to override Jetty's default QueuedThreadPool and give the gravitee context class loader to created threads.