Revert "fix: instantiate the right inputStream instead of relying on …

…the registry" This reverts commit 3c57598.
gravitee-io · Nov 3, 2021 · fc54c19 · fc54c19
1 parent 86a4c1b
commit fc54c19
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 16 deletions.
diff --git a/...portal-rest/src/main/java/io/gravitee/rest/api/portal/rest/resource/AbstractResource.java b/...portal-rest/src/main/java/io/gravitee/rest/api/portal/rest/resource/AbstractResource.java
@@ -16,7 +16,6 @@
 package io.gravitee.rest.api.portal.rest.resource;
 
 import com.fasterxml.jackson.annotation.JsonInclude;
-import com.twelvemonkeys.imageio.stream.ByteArrayImageInputStream;
 import io.gravitee.rest.api.idp.api.authentication.UserDetails;
 import io.gravitee.rest.api.model.InlinePictureEntity;
 import io.gravitee.rest.api.model.MediaEntity;
@@ -154,13 +153,7 @@ String checkAndScaleImage(final String encodedPicture) {
             }
 
             try {
-                /*
-                 * For an unknown reason, when running APIM from jar/zip instead of sourcecode, com.twelvemonkeys.imageio.stream.ByteArrayImageInputStreamSpi
-                 *  is not registered in the IIORegistry used by ImageIO to manage stream.
-                 * So basically the hack is to directly instantiate a ByteArrayImageInputStream
-                 */
-                //ImageInputStream imageInputStream = ImageIO.createImageInputStream(decodedPicture);
-                ImageInputStream imageInputStream = new ByteArrayImageInputStream(decodedPicture);
+                ImageInputStream imageInputStream = ImageIO.createImageInputStream(decodedPicture);
                 Iterator<ImageReader> imageReaders = ImageIO.getImageReaders(imageInputStream);
 
                 while (imageReaders.hasNext()) {

diff --git a/...-apim-rest-api-security/src/main/java/io/gravitee/rest/api/security/utils/ImageUtils.java b/...-apim-rest-api-security/src/main/java/io/gravitee/rest/api/security/utils/ImageUtils.java
@@ -15,7 +15,6 @@
  */
 package io.gravitee.rest.api.security.utils;
 
-import com.twelvemonkeys.imageio.stream.ByteArrayImageInputStream;
 import io.gravitee.rest.api.exception.InvalidImageException;
 import java.awt.*;
 import java.awt.image.BufferedImage;
@@ -115,13 +114,7 @@ private static Image decodePicture(String picture) throws InvalidImageException
 
     private static Image rescale(Image image, int width, int height) throws InvalidImageException {
         try {
-            /*
-             * For an unknown reason, when running APIM from jar/zip instead of sourcecode, com.twelvemonkeys.imageio.stream.ByteArrayImageInputStreamSpi
-             *  is not registered in the IIORegistry used by ImageIO to manage stream.
-             * So basically the hack is to directly instantiate a ByteArrayImageInputStream
-             */
-            //ImageInputStream imageInputStream = ImageIO.createImageInputStream(image.getData());
-            ImageInputStream imageInputStream = new ByteArrayImageInputStream(image.getData());
+            ImageInputStream imageInputStream = ImageIO.createImageInputStream(image.getData());
             Iterator<ImageReader> imageReaders = ImageIO.getImageReaders(imageInputStream);
 
             while (imageReaders.hasNext()) {