Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use require.Eventually to avoid flakiness in TestAPILockedOut #9513

Merged
merged 1 commit into from
Dec 31, 2021
Merged

Use require.Eventually to avoid flakiness in TestAPILockedOut #9513

merged 1 commit into from
Dec 31, 2021

Conversation

lxea
Copy link
Contributor

@lxea lxea commented Dec 21, 2021 •
edited

I was able to reproduce flakiness at each location in the test where I've added require.Eventually.

After adding this I observed the tests passing when run with -count=5 and 100 subtests with t.Parallel()

@github-actions github-actions bot requested review from quinqu and zmb3 December 21, 2021 11:29
@lxea lxea force-pushed the lxea/apilockedoutflakey branch 2 times, most recently from 69758ae to 35a72c2 Compare December 23, 2021 16:30
@lxea lxea requested a review from zmb3 December 30, 2021 11:51
@lxea lxea enabled auto-merge (rebase) December 31, 2021 12:30
@lxea lxea merged commit b569adc into master Dec 31, 2021
@lxea lxea deleted the lxea/apilockedoutflakey branch December 31, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmb3 zmb3 zmb3 approved these changes

@quinqu quinqu quinqu approved these changes

Assignees
No one assigned
Labels
flaky tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lxea @zmb3 @quinqu @rosstimothy