Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor our logrus fork to fix data race #7940

Merged
merged 3 commits into from Aug 17, 2021
Merged

Vendor our logrus fork to fix data race #7940

merged 3 commits into from Aug 17, 2021

Conversation

r0mant
Copy link
Collaborator

@r0mant r0mant commented Aug 17, 2021 •
edited

Revendor our own copy of logrus again with a data race fix which isn't merged upstream: gravitational/logrus#7.

@r0mant r0mant self-assigned this Aug 17, 2021
@r0mant r0mant requested a review from russjones August 17, 2021 00:49
@r0mant r0mant marked this pull request as ready for review August 17, 2021 00:50
@r0mant r0mant enabled auto-merge (squash) August 17, 2021 00:51
russjones
russjones approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@russjones russjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bot.

@r0mant r0mant merged commit 060750b into master Aug 17, 2021
@r0mant r0mant deleted the roman/logrusrace branch August 17, 2021 19:58
zmb3 pushed a commit that referenced this pull request Sep 23, 2021
@r0mant @zmb3
Vendor our logrus fork to fix data race (#7940)
c6299b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russjones russjones russjones approved these changes

@klizhentas klizhentas Awaiting requested review from klizhentas

Assignees

@r0mant r0mant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r0mant @russjones