Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go dependencies #5681

Merged
merged 3 commits into from Feb 24, 2021
Merged

Update Go dependencies #5681

merged 3 commits into from Feb 24, 2021

Conversation

awly
Copy link
Contributor

@awly awly commented Feb 23, 2021

Several dependencies can't be updated due to breakages (etcd and grpc
for example).

Also updated ttlmap usage since their API changed.

@russjones
Copy link
Contributor

russjones commented Feb 23, 2021

@awly Bumping ttlmap is a little concerning because I think there were some internal changes in behavior? @fspmarshall I think you mentioned some to me as well?

@awly
Copy link
Contributor Author

awly commented Feb 23, 2021

@russjones yeah, looks like gravitational/ttlmap#2 at least dropped the .Remove method, which doesn't exist in upstream ttlmap.
I reverted that version bump.

@awly
Copy link
Contributor Author

awly commented Feb 23, 2021

The race in logrus was fixed in sirupsen/logrus#1234
Let me bump that dep to master...

@awly awly force-pushed the andrew/update-deps branch 2 times, most recently from 15cce8b to 407a5b0 Compare February 24, 2021 00:51
Andrew Lytvynov added 2 commits February 23, 2021 17:03
Several dependencies can't be updated due to breakages (etcd and grpc
for example).

Also updated ttlmap usage since their API changed.
This prevents data races between changing the standard logger and it
acutally being used.
go.mod Show resolved Hide resolved
@russjones russjones merged commit 485856f into master Feb 24, 2021
@russjones russjones deleted the andrew/update-deps branch February 24, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants