Add support for access request notifications #41621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudream
force-pushed
the
yassine/notifications/access-requests
branch
from
e5ec220
to
ebf46c5
Compare
rudream
commented
May 15, 2024
rudream
commented
May 15, 2024
rudream
force-pushed
the
yassine/notifications/access-requests
branch
2 times, most recently
from
13ed4d7
to
847ff09
Compare
gzdunek
approved these changes
May 16, 2024
avatus
reviewed
May 16, 2024
rudream
force-pushed
the
yassine/notifications/access-requests
branch
from
43a41ca
to
aed8ab5
Compare
gzdunek
reviewed
May 17, 2024
|
Idk if it's just me, but the current buttons for toggling the notification kind seem too large 😅 If you agree, I'd ask the design team for a confirmation. |
gzdunek
approved these changes
May 20, 2024
rudream
force-pushed
the
yassine/notifications/access-requests
branch
from
578b385
to
3268332
Compare
rudream
force-pushed
the
yassine/notifications/access-requests
branch
from
cba98ac
to
6605d07
Compare
rudream
force-pushed
the
yassine/notifications/access-requests
branch
from
6605d07
to
1f53170
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Part of #37704
Adds support for access request notifications. Creating an access request will notify users capable of reviewing it, and approving or denying it will notify the requester.
ecounterpart: https://github.com/gravitational/teleport.e/pull/4173Demo
From reviewer POV:
From requester POV:
Access request assumed state:
Access request not yet assumable (if it's scheduled) state:
Access request assume error state:
changelog: Added access request notifications.