Add TestModules #10369
Merged
Add TestModules #10369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
database-access
jimbishopp
force-pushed
the
jim/fixtestmodules
branch
from
2844f4e
to
73a7ea0
Compare
zmb3
approved these changes
Feb 15, 2022
jimbishopp
force-pushed
the
jim/fixtestmodules
branch
from
73a7ea0
to
7c6e992
Compare
codingllama
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
TestModuleswhich allows tests to set fake values to be returned frommodules.GetModules(). The pattern implemented is an extension of the pattern used when implementing #10355.All tests that require test modules have been refactored to use this new implementation.
In some cases, multiple tests in the same package/file require the same features. In such cases, I opted to not create a separate function to set the features and instead inlined each call. Having the features visible in each test outweighed the benefit of saving a few lines of code.
Updates: #9492