Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Broken links on Introspection route #1054

Closed

Conversation

shan7030
Copy link

@shan7030 shan7030 commented May 26, 2021

Description

  1. Fixed the link to starWarsIntrospection-test.ts in Introspection section which is recently migrated to .ts from .js
  2. Fixed the link to introspection file in GraphQL.js which is recently migrated to .ts from .js

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 26, 2021

CLA Not Signed

@shan7030 shan7030 changed the title Fixed Introspection example link Fixed Broken links on Introspection route May 26, 2021
@saihaj
Copy link
Member

saihaj commented May 26, 2021

Hey @shan7030 thanks for the changes. There are possibly many broken links because of TS migration. These docs are outdated and something we plan to work and improve on as part of v16 release plan graphql/graphql-js#2860 . Idea is to generate API docs using TS doc so we have latest docs

@shan7030
Copy link
Author

shan7030 commented May 27, 2021

Hi @saihaj , thanks for updating me about this. So, do I close this PR or would it be good idea to merge this for the time being?

@saihaj
Copy link
Member

saihaj commented May 29, 2021

I guess we can merge this in for time being. I will be making a meta issue to track all the documentation related issues so that everything can be addressed.

@saihaj
Copy link
Member

saihaj commented Jun 2, 2021

Resolved in #1056 @brianwarner we can close this

@brianwarner
Copy link
Contributor

Thank you! I've just merged the other PR.

@brianwarner brianwarner closed this Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants