perf: use undefined for empty #4046
Merged
+150
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
force-pushed
the
use-undefined-for-empty
branch
from
526d0ad
to
86bcda3
Compare
yaacovCR
added
the
PR: polish 💅
yaacovCR
force-pushed
the
use-undefined-for-empty
branch
2 times, most recently
from
2e2b1b2
to
1ce2956
Compare
|
|
yaacovCR
force-pushed
the
use-undefined-for-empty
branch
from
1ce2956
to
883cfbf
Compare
yaacovCR
force-pushed
the
use-undefined-for-empty
branch
from
883cfbf
to
e144e82
Compare
yaacovCR
force-pushed
the
use-undefined-for-empty
branch
from
e144e82
to
8ff203d
Compare
yaacovCR
added a commit
that referenced
this pull request
Apr 18, 2024
following graphql/graphql-spec#1077 now part of the following PR stack, with the laters PRs extracted from this one #4026: incremental: introduce GraphQLWrappedResult to avoid filtering #4050: perf: allow skipping of field plan generation #4051: perf: introduce completePromisedListItemValue #4052: refactor: introduce completeIterableValue #4053: perf: optimize completion loops #4046: perf: use undefined for empty
yaacovCR
force-pushed
the
use-undefined-for-empty
branch
2 times, most recently
from
195c372
to
300af34
Compare
yaacovCR
force-pushed
the
use-undefined-for-empty
branch
from
300af34
to
37f6e88
Compare
|
took out dependence on #4053
|
robrichard
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As convention, we will lazily instantiate arrays/sets when adding the first item.
This applies to arrays/sets on execution/incremental context, as well as the second member of the GraphQLWrappedResult tuple holding the array of incremental data records.