allow unions to declare implementation of interfaces #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
added a commit
to graphql/graphql-wg
that referenced
this pull request
Apr 5, 2022
- Spec PR: graphql/graphql-spec#939 - graphql-js PR (WIP): graphql/graphql-js#3527
benjie
added a commit
to graphql/graphql-wg
that referenced
this pull request
Apr 5, 2022
* add agenda item for unions implementing interfaces - Spec PR: graphql/graphql-spec#939 - graphql-js PR (WIP): graphql/graphql-js#3527 * Update agendas/2022/2022-04-07.md Co-authored-by: Benjie Gillam <benjie@jemjie.com>
yaacovCR
changed the title
yaacovCR
added
the
spec RFC
So, this rule would possibly need to be updated for a union to find the field on one of the interfaces it implements! |
yaacovCR
added a commit
to yaacovCR/graphql-executor
that referenced
this pull request
Apr 29, 2022
Intersections of unions and interfaces can be considered to "implement" their unions and interface members. A type with a field of type Intersection will satisfy an interface where the field defined in the interface is one of the member types of the intersection. Alternative to graphql#3527
yaacovCR
added a commit
to yaacovCR/graphql-executor
that referenced
this pull request
Apr 29, 2022
Intersections of unions and interfaces can be considered to "implement" their unions and interface members. A type with a field of type Intersection will satisfy an interface where the field defined in the interface is one of the member types of the intersection. Alternative to graphql#3527
yaacovCR
added a commit
to yaacovCR/graphql-executor
that referenced
this pull request
Apr 29, 2022
Intersections of unions and interfaces can be considered to "implement" their unions and interface members. A type with a field of type Intersection will satisfy an interface where the field defined in the interface is one of the member types of the intersection. Alternative to graphql#3527
yaacovCR
added a commit
to yaacovCR/graphql-executor
that referenced
this pull request
Apr 29, 2022
Intersections of unions and interfaces can be considered to "implement" their unions and interface members. A type with a field of type Intersection will satisfy an interface where the field defined in the interface is one of the member types of the intersection. Alternative to graphql#3527
yaacovCR
added a commit
to yaacovCR/graphql-executor
that referenced
this pull request
Apr 29, 2022
Intersections of unions and interfaces can be considered to "implement" their unions and interface members. A type with a field of type Intersection will satisfy an interface where the field defined in the interface is one of the member types of the intersection. Alternative to graphql#3527
yaacovCR
added a commit
to yaacovCR/graphql-executor
that referenced
this pull request
Apr 30, 2022
Intersections of unions and interfaces can be considered to "implement" their unions and interface members. A type with a field of type Intersection will satisfy an interface where the field defined in the interface is one of the member types of the intersection. Alternative to graphql#3527
yaacovCR
added a commit
to yaacovCR/graphql-executor
that referenced
this pull request
May 3, 2022
Intersections of unions and interfaces can be considered to "implement" their unions and interface members. A type with a field of type Intersection will satisfy an interface where the field defined in the interface is one of the member types of the intersection. Alternative to graphql#3527
yaacovCR
added a commit
to yaacovCR/graphql-executor
that referenced
this pull request
May 3, 2022
Intersections of unions and interfaces can be considered to "implement" their unions and interface members. A type with a field of type Intersection will satisfy an interface where the field defined in the interface is one of the member types of the intersection. Alternative to graphql#3527
yaacovCR
added a commit
to yaacovCR/graphql-executor
that referenced
this pull request
May 3, 2022
Intersections of unions and interfaces can be considered to "implement" their unions and interface members. A type with a field of type Intersection will satisfy an interface where the field defined in the interface is one of the member types of the intersection. Alternative to graphql#3527
yaacovCR
added a commit
to yaacovCR/graphql-executor
that referenced
this pull request
May 3, 2022
Intersections of unions and interfaces can be considered to "implement" their unions and interface members. A type with a field of type Intersection will satisfy an interface where the field defined in the interface is one of the member types of the intersection. Alternative to graphql#3527
yaacovCR
added a commit
to yaacovCR/graphql-executor
that referenced
this pull request
May 3, 2022
Intersections of unions and interfaces can be considered to "implement" their unions and interface members. A type with a field of type Intersection will satisfy an interface where the field defined in the interface is one of the member types of the intersection. Alternative to graphql#3527
yaacovCR
force-pushed
the
union
branch
4 times, most recently
from
6f229f7
to
ecd0e3c
Compare
|
Decision Record We decided at the last WG that if unions implement interfaces, then they have directly querable fields. This PR and the spec PR have been updated with the changes for introspection, validation. Now all composite types have a |
WIP: more tests required complete code coverage is already there, but goal is to have a test where union implements an interface wherever there is a test for an interface implementing interface
|
Actually, this naive field copying from the interfaces to the Union does not account for different interfaces with valid overlapping fields like new arguments with defaults. Work to do! |
mattstern31
pushed a commit
to mattstern31/graphql-wg-membership-note
that referenced
this pull request
Dec 1, 2022
* add agenda item for unions implementing interfaces - Spec PR: graphql/graphql-spec#939 - graphql-js PR (WIP): graphql/graphql-js#3527 * Update agendas/2022/2022-04-07.md Co-authored-by: Benjie Gillam <benjie@jemjie.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: graphql/graphql-spec#939