v16 regression: parsed GraphQL comments has invalid (negative) token.column
#3353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotansimha Thanks for the test case. I will take a look. |
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Nov 1, 2021
IvanGoncharov
added a commit
that referenced
this pull request
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on
graphql-eslint(dimaMachina/graphql-eslint#724) and upgrading it to v16, we noticed that parsed comments has negative values instartToken.column. v15 was working fine.Managed to add a failing test to ensure all columns are positive. I think it happens only when there are GraphQL comments at the beginning of the document.
@IvanGoncharov @saihaj thoughts?