Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Changed how to import graphqlHTTP in graphql-express modules #2693

Merged
merged 3 commits into from Jul 7, 2020
Merged

docs: Changed how to import graphqlHTTP in graphql-express modules #2693

merged 3 commits into from Jul 7, 2020

Conversation

solidw
Copy link
Contributor

@solidw solidw commented Jul 7, 2020

overview

I just followed the document at graphql-js tutorials.

But there is problem when I import graphqlHTTP from 'express-grapqhl'.
image
(The squared black blank is my user name.)

Because they updated express-grapqhl modules and updated official README.md 27 days ago. express-graphql history (see below image)
image

So I changed require statement in graphql-js tutorials.
var graphqlHTTP = require('express-graphql')
to
var { graphqlHTTP } = require('express-graphql')

And it works!
image

@danielrearden
Copy link
Contributor

@solidw Thanks for submitting this PR!

@IvanGoncharov IvanGoncharov merged commit 0e88044 into graphql:master Jul 7, 2020
@solidw solidw deleted the fix-express-graphql-tutorial-docs branch July 23, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants