Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2504 access field astNode's type by optional chaining #2513

Merged
merged 1 commit into from
May 7, 2020
Merged

Fix #2504 access field astNode's type by optional chaining #2513

merged 1 commit into from
May 7, 2020

Conversation

josephktcheung
Copy link
Contributor

@josephktcheung josephktcheung commented Apr 17, 2020 •
edited

This is to fix #2504 regression that throws TypeError not normal GraphQLError when running validateTypeImplementsInterface if astNode is not provided to GraphQLType

@josephktcheung josephktcheung mentioned this pull request Apr 17, 2020
Closed
@IvanGoncharov IvanGoncharov merged commit 122b305 into graphql:master May 7, 2020
@IvanGoncharov
Copy link
Member

@josephktcheung Big thanks for investigating and fixing this issue 👍
The only question left: Why Flow didn't catch this?
But we plan to switch to TS so it's not a big deal.

@IvanGoncharov IvanGoncharov added the PR: bug fix 🐞 requires increase of "patch" version number label Jun 7, 2020
MrOrz added a commit to cofacts/rumors-api that referenced this pull request Sep 13, 2020
@MrOrz
[package.json] upgrade graphql to get better interface error during d…
7bcd193 
…evelopment

@see graphql/graphql-js#2513
@MrOrz MrOrz mentioned this pull request Sep 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError in validateTypeImplementsInterface
2 participants
@josephktcheung @IvanGoncharov