Use replaceAll instead of RegExp with global flag (#3856)

graphql · Feb 26, 2023 · e171a14 · e171a14
1 parent 7e6844c
commit e171a14
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 7 deletions.
diff --git a/integrationTests/node/test.js b/integrationTests/node/test.js
@@ -6,8 +6,9 @@ const graphqlPackageJSON = JSON.parse(
 );
 
 const nodeVersions = graphqlPackageJSON.engines.node
+  .replaceAll('^', '')
+  .replaceAll('>=', '')
   .split(' || ')
-  .map((version) => version.replace('^', '').replace('>=', ''))
   .sort((a, b) => b.localeCompare(a));
 
 for (const version of nodeVersions) {

diff --git a/src/__testUtils__/dedent.ts b/src/__testUtils__/dedent.ts
@@ -12,7 +12,7 @@ export function dedentString(string: string): string {
     indent += char;
   }
 
-  return trimmedStr.replace(RegExp('^' + indent, 'mg'), ''); // remove indent
+  return trimmedStr.replaceAll(RegExp('^' + indent, 'mg'), ''); // remove indent
 }
 
 /**

diff --git a/src/__testUtils__/inspectStr.ts b/src/__testUtils__/inspectStr.ts
@@ -9,6 +9,6 @@ export function inspectStr(str: Maybe<string>): string {
   }
   return JSON.stringify(str)
     .replace(/^"|"$/g, '`')
-    .replace(/\\"/g, '"')
-    .replace(/\\\\/g, '\\');
+    .replaceAll('\\"', '"')
+    .replaceAll('\\\\', '\\');
 }
diff --git a/src/language/blockString.ts b/src/language/blockString.ts
@@ -122,7 +122,7 @@ export function printBlockString(
   value: string,
   options?: { minimize?: boolean },
 ): string {
-  const escapedValue = value.replace(/"""/g, '\\"""');
+  const escapedValue = value.replaceAll('"""', '\\"""');
 
   // Expand a block string's raw value into independent lines.
   const lines = escapedValue.split(/\r\n|[\n\r]/g);

diff --git a/src/language/printer.ts b/src/language/printer.ts
@@ -370,7 +370,7 @@ function wrap(
 }
 
 function indent(str: string): string {
-  return wrap('  ', str.replace(/\n/g, '\n  '));
+  return wrap('  ', str.replaceAll('\n', '\n  '));
 }
 
 function hasMultilineItems(maybeArray: Maybe<ReadonlyArray<string>>): boolean {

diff --git a/src/utilities/printSchema.ts b/src/utilities/printSchema.ts
@@ -317,5 +317,5 @@ function printDescription(
   const prefix =
     indentation && !firstInBlock ? '\n' + indentation : indentation;
 
-  return prefix + blockString.replace(/\n/g, '\n' + indentation) + '\n';
+  return prefix + blockString.replaceAll('\n', '\n' + indentation) + '\n';
 }