ValidationContext: Remove deprecated 'getErrors' and make 'onEr… (#2130)

graphql · Sep 15, 2019 · dd6dd3c · dd6dd3c
1 parent a7cc223
commit dd6dd3c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 19 deletions.
diff --git a/src/validation/ValidationContext.js b/src/validation/ValidationContext.js
@@ -41,34 +41,24 @@ type VariableUsage = {|
  */
 export class ASTValidationContext {
   _ast: DocumentNode;
-  _onError: ?(err: GraphQLError) => void;
-  _errors: Array<GraphQLError>;
+  _onError: (err: GraphQLError) => void;
   _fragments: ?ObjMap<FragmentDefinitionNode>;
   _fragmentSpreads: Map<SelectionSetNode, $ReadOnlyArray<FragmentSpreadNode>>;
   _recursivelyReferencedFragments: Map<
     OperationDefinitionNode,
     $ReadOnlyArray<FragmentDefinitionNode>,
   >;
 
-  constructor(ast: DocumentNode, onError?: (err: GraphQLError) => void): void {
+  constructor(ast: DocumentNode, onError: (err: GraphQLError) => void): void {
     this._ast = ast;
-    this._errors = [];
     this._fragments = undefined;
     this._fragmentSpreads = new Map();
     this._recursivelyReferencedFragments = new Map();
     this._onError = onError;
   }
 
   reportError(error: GraphQLError): void {
-    this._errors.push(error);
-    if (this._onError) {
-      this._onError(error);
-    }
-  }
-
-  // @deprecated: use onError callback instead - will be removed in v15.
-  getErrors(): $ReadOnlyArray<GraphQLError> {
-    return this._errors;
+    this._onError(error);
   }
 
   getDocument(): DocumentNode {
@@ -175,7 +165,7 @@ export class ValidationContext extends ASTValidationContext {
     schema: GraphQLSchema,
     ast: DocumentNode,
     typeInfo: TypeInfo,
-    onError?: (err: GraphQLError) => void,
+    onError: (err: GraphQLError) => void,
   ): void {
     super(ast, onError);
     this._schema = schema;

diff --git a/tstypes/validation/ValidationContext.d.ts b/tstypes/validation/ValidationContext.d.ts
@@ -33,12 +33,10 @@ type VariableUsage = {
  * validation rule.
  */
 export class ASTValidationContext {
-  constructor(ast: DocumentNode);
+  constructor(ast: DocumentNode, onError: (err: GraphQLError) => void);
 
   reportError(error: GraphQLError): undefined;
 
-  getErrors(): ReadonlyArray<GraphQLError>;
-
   getDocument(): DocumentNode;
 
   getFragment(name: string): Maybe<FragmentDefinitionNode>;
@@ -54,7 +52,7 @@ export class SDLValidationContext extends ASTValidationContext {
   constructor(
     ast: DocumentNode,
     schema: Maybe<GraphQLSchema>,
-    onError?: (err: GraphQLError) => void,
+    onError: (err: GraphQLError) => void,
   );
 
   getSchema(): Maybe<GraphQLSchema>;
@@ -67,7 +65,7 @@ export class ValidationContext extends ASTValidationContext {
     schema: GraphQLSchema,
     ast: DocumentNode,
     typeInfo: TypeInfo,
-    onError?: (err: GraphQLError) => void,
+    onError: (err: GraphQLError) => void,
   );
 
   getSchema(): GraphQLSchema;