GraphQLArgument: make 'description' undefined by default (#2132)

graphql · Sep 15, 2019 · 4c4df72 · 4c4df72
1 parent 564e35a
commit 4c4df72
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/src/type/__tests__/definition-test.js b/src/type/__tests__/definition-test.js
@@ -243,7 +243,7 @@ describe('Type System: Objects', () => {
         args: [
           {
             name: 'arg',
-            description: null,
+            description: undefined,
             type: ScalarType,
             defaultValue: undefined,
             extensions: undefined,

diff --git a/src/type/__tests__/directive-test.js b/src/type/__tests__/directive-test.js
@@ -36,15 +36,15 @@ describe('Type System: Directive', () => {
       args: [
         {
           name: 'foo',
-          description: null,
+          description: undefined,
           type: GraphQLString,
           defaultValue: undefined,
           extensions: undefined,
           astNode: undefined,
         },
         {
           name: 'bar',
-          description: null,
+          description: undefined,
           type: GraphQLInt,
           defaultValue: undefined,
           extensions: undefined,

diff --git a/src/type/definition.js b/src/type/definition.js
@@ -783,7 +783,7 @@ function defineFieldMap<TSource, TContext>(
 
     const args = objectEntries(argsConfig).map(([argName, arg]) => ({
       name: argName,
-      description: arg.description === undefined ? null : arg.description,
+      description: arg.description,
       type: arg.type,
       defaultValue: arg.defaultValue,
       extensions: arg.extensions && toObjMap(arg.extensions),

diff --git a/src/type/directives.js b/src/type/directives.js
@@ -83,7 +83,7 @@ export class GraphQLDirective {
 
     this.args = objectEntries(args).map(([argName, arg]) => ({
       name: argName,
-      description: arg.description === undefined ? null : arg.description,
+      description: arg.description,
       type: arg.type,
       defaultValue: arg.defaultValue,
       extensions: arg.extensions && toObjMap(arg.extensions),