Enable 'prefer-promise-reject-errors' ESLint rule (#1882)

graphql · May 21, 2019 · 176aa7f · 176aa7f
1 parent b1a39de
commit 176aa7f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.eslintrc.yml b/.eslintrc.yml
@@ -163,7 +163,7 @@ rules:
   no-warning-comments: off # TODO
   no-with: error
   prefer-named-capture-group: off # ES2018
-  prefer-promise-reject-errors: off # TODO
+  prefer-promise-reject-errors: error
   radix: error
   require-await: off # TODO
   require-unicode-regexp: off

diff --git a/src/execution/__tests__/executor-test.js b/src/execution/__tests__/executor-test.js
@@ -414,9 +414,11 @@ describe('Execute: Handles basic execution tasks', () => {
         );
       },
       asyncRawReject() {
+        // eslint-disable-next-line prefer-promise-reject-errors
         return Promise.reject('Error getting asyncRawReject');
       },
       asyncEmptyReject() {
+        // eslint-disable-next-line prefer-promise-reject-errors
         return Promise.reject();
       },
       asyncError() {