Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ts path resolution, for #2260 #2261

Merged
merged 1 commit into from Mar 30, 2022
Merged

fix ts path resolution, for #2260 #2261

merged 1 commit into from Mar 30, 2022

Conversation

acao
Copy link
Member

@acao acao commented Mar 30, 2022

this should resolve #2260. i cannot recreate the bug inside the repository for some reason so I'm not sure. the canary will appear and can be used!

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2022

🦋 Changeset detected

Latest commit: 5b22226

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
codemirror-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@acao acao force-pushed the codemirror-graphql-path-bug branch from b56e169 to 5b22226 Compare March 30, 2022 11:36
@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2022

The latest changes of this PR are available as canary in npm (based on the declared changesets):

codemirror-graphql@1.2.15-canary-e0939150.0
graphiql@1.8.2-canary-e0939150.0

@acao acao requested a review from imolorhe March 30, 2022 11:37
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #2261 (5b22226) into main (2d91916) will decrease coverage by 0.99%.
The diff coverage is 74.00%.

@@            Coverage Diff             @@
##             main    #2261      +/-   ##
==========================================
- Coverage   65.70%   64.71%   -1.00%     
==========================================
  Files          85       81       -4     
  Lines        5106     5314     +208     
  Branches     1631     1700      +69     
==========================================
+ Hits         3355     3439      +84     
- Misses       1747     1871     +124     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ackages/codemirror-graphql/src/utils/info-addon.ts 1.02% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3232dc9...5b22226. Read the comment docs.

@acao acao merged commit 261f204 into main Mar 30, 2022
@acao acao deleted the codemirror-graphql-path-bug branch March 30, 2022 13:27
@github-actions github-actions bot mentioned this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import interface with absolute path
1 participant