Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove type definition from vulnerable library #1990

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

acao
Copy link
Member

@acao acao commented Oct 28, 2021

fixes #1989

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2021

🦋 Changeset detected

Latest commit: cea4096

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
graphiql Patch
@graphiql/toolkit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2021

@github-actions github-actions bot temporarily deployed to graphiql-1 October 28, 2021 14:02 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2021

@github-actions github-actions bot temporarily deployed to monaco-graphql October 28, 2021 14:02 Inactive
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #1990 (1f25423) into main (2d91916) will increase coverage by 0.75%.
The diff coverage is 69.23%.

❗ Current head 1f25423 differs from pull request most recent head cea4096. Consider uploading reports for the commit cea4096 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1990      +/-   ##
==========================================
+ Coverage   65.70%   66.45%   +0.75%     
==========================================
  Files          85       86       +1     
  Lines        5106     5143      +37     
  Branches     1631     1640       +9     
==========================================
+ Hits         3355     3418      +63     
+ Misses       1747     1721      -26     
  Partials        4        4              
Impacted Files Coverage Δ
...ackages/graphiql-toolkit/src/create-fetcher/lib.ts 50.90% <33.33%> (-8.67%) ⬇️
packages/graphiql/src/utility/HistoryStore.ts 62.26% <62.26%> (ø)
packages/graphiql/src/components/QueryHistory.tsx 73.91% <76.47%> (+6.69%) ⬆️
...iql/src/components/DocExplorer/MarkdownContent.tsx 100.00% <100.00%> (ø)
packages/graphiql/src/components/GraphiQL.tsx 58.34% <100.00%> (+0.83%) ⬆️
...ql-language-service-server/src/MessageProcessor.ts 66.66% <100.00%> (+6.38%) ⬆️
...hql-language-service-server/src/findGraphQLTags.ts 67.64% <100.00%> (+7.00%) ⬆️
...raphql-language-service-server/src/GraphQLCache.ts 52.25% <0.00%> (+0.60%) ⬆️
packages/graphiql/src/utility/QueryStore.ts 42.85% <0.00%> (+2.04%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ad2c0c...cea4096. Read the comment docs.

@acao acao merged commit 62e786b into main Oct 28, 2021
@acao acao deleted the chore/toolkit-type-bug branch October 28, 2021 14:04
@github-actions github-actions bot temporarily deployed to graphiql-1 October 28, 2021 14:07 Inactive
@github-actions github-actions bot mentioned this pull request Oct 28, 2021
@github-actions github-actions bot temporarily deployed to monaco-graphql October 28, 2021 14:07 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete TypeScript typings in @graphiql/toolkit@0.3.0
1 participant