Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @graphiql/toolkit dependencies #1968

Merged
merged 2 commits into from Oct 10, 2021
Merged

Conversation

acao
Copy link
Member

@acao acao commented Oct 10, 2021

Made the mistake of adding optionalDependencies to @graphiql/toolkit, some of which are vulnerable.

This reverts that, and increments versions to the latest of graphql-ws, meros, and @n1ru4l/push-pull-async-iterable-iterator

Question: should these be peerDependencies and documentation updated to reflect this?

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2021

🦋 Changeset detected

Latest commit: 620e65b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphiql/toolkit Minor
graphiql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@acao acao changed the title fix: graphiql-toolkit dependencies fix: @graphiql/toolkit dependencies Oct 10, 2021
@codecov
Copy link

codecov bot commented Oct 10, 2021

Codecov Report

Merging #1968 (620e65b) into main (2d91916) will increase coverage by 0.18%.
The diff coverage is 68.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1968      +/-   ##
==========================================
+ Coverage   65.70%   65.89%   +0.18%     
==========================================
  Files          85       86       +1     
  Lines        5106     5143      +37     
  Branches     1631     1640       +9     
==========================================
+ Hits         3355     3389      +34     
- Misses       1747     1750       +3     
  Partials        4        4              
Impacted Files Coverage Δ
...ackages/graphiql-toolkit/src/create-fetcher/lib.ts 50.90% <20.00%> (-8.67%) ⬇️
packages/graphiql/src/utility/HistoryStore.ts 62.26% <62.26%> (ø)
packages/graphiql/src/components/QueryHistory.tsx 73.91% <76.47%> (+6.69%) ⬆️
...iql/src/components/DocExplorer/MarkdownContent.tsx 100.00% <100.00%> (ø)
packages/graphiql/src/components/GraphiQL.tsx 58.34% <100.00%> (+0.83%) ⬆️
...hql-language-service-server/src/findGraphQLTags.ts 67.64% <100.00%> (+7.00%) ⬆️
packages/graphiql/src/utility/QueryStore.ts 42.85% <0.00%> (+2.04%) ⬆️
packages/graphiql/src/components/ToolbarButton.tsx 92.85% <0.00%> (+21.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec37c6...620e65b. Read the comment docs.

@acao acao merged commit 6a459f4 into graphql:main Oct 10, 2021
@github-actions github-actions bot mentioned this pull request Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant