Fix css theme override on result window #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close graphql#1919 `editorTheme` option apply theme uniformly on all the codemirror instances so we can considerate that this background is specific to the graphiql theme. Other theme should be able to override correctly this color.
🦋 Changeset detectedLatest commit: f88ec3a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
|
Excellent fix, thank you! |
Codecov Report
@@ Coverage Diff @@
## main #1923 +/- ##
==========================================
+ Coverage 65.70% 65.81% +0.10%
==========================================
Files 85 85
Lines 5106 5116 +10
Branches 1631 1636 +5
==========================================
+ Hits 3355 3367 +12
+ Misses 1747 1745 -2
Partials 4 4
Continue to review full report at Codecov.
|
acao
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1919
editorThemeoption apply theme uniformly on all the codemirror instances so we can considerate that this background is specific to the graphiql theme. Other theme should be able to override correctly this color.