New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: new util to manage historyStore outside of query history component #1914
Conversation
🦋 Changeset detectedLatest commit: 1a362e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
45bfb06
to
7419c58
Compare
Codecov Report
@@ Coverage Diff @@
## main #1914 +/- ##
==========================================
+ Coverage 65.70% 65.84% +0.13%
==========================================
Files 85 86 +1
Lines 5106 5135 +29
Branches 1631 1638 +7
==========================================
+ Hits 3355 3381 +26
- Misses 1747 1750 +3
Partials 4 4
Continue to review full report at Codecov.
|
7419c58
to
f261e87
Compare
According to the discussion in #1782 Created a new prop, which will allow passing in maxHistoryLength. To default, it is set to 20. |
a54cd9e
to
d3b3b84
Compare
d3b3b84
to
1a362e6
Compare
awesome, thank you @harshithpabbati ! |
@harshithpabbati I think this means we have several unused files to delete in |
I don't think there are any unused files. |
@harshithpabbati I see now, after a closer reading, thank you! |
Waiting for graphql/graphiql#1914 changes to be released
fixes: #1892
Since the history store is inside the query history panel, it's not getting updated until we open the panel, so instead, I created a new historyStore util to manage the store.