feat: export ToolbarSelectOption and ToolbarMenuItem #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e66257d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
henryqdineen
force-pushed
the
hqd-new-exports
branch
from
16820b8
to
e66257d
Compare
Codecov Report
@@ Coverage Diff @@
## main #1889 +/- ##
==========================================
+ Coverage 65.70% 65.81% +0.10%
==========================================
Files 85 85
Lines 5106 5116 +10
Branches 1631 1636 +5
==========================================
+ Hits 3355 3367 +12
+ Misses 1747 1745 -2
Partials 4 4
Continue to review full report at Codecov.
|
|
awesome thank you! those GraphiQL.ComponentName interfaces were dropped as noted here so we could upgrade react: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
ToolbarSelectis exported from the index module butToolbarSelectOptionisn't. We are upgrading from v0.14.2 to v1.4.2 and noticed that theGraphiQL.SelectandGraphiQL.SelectOptionproperties are no longer available and appear to be commented out. When looking at moving over toToolbarSelectit seemed like it would be better ifToolbarSelectOptionwas also exported.ToolbarMenu/ToolbarMenuItemalso appears to have the same issue.Thanks!