Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating #999 font colors to #666 #1883

Merged

Conversation

Sweetabix1
Copy link
Contributor

Updating font colors for line numbers, comments & brackets from #999 to #666 for accessibility purposes. #666 passes AA accessibility standards for small text, with a contrast ratio of over 5:1.

@changeset-bot
Copy link

changeset-bot bot commented Jun 4, 2021

🦋 Changeset detected

Latest commit: a81ed75

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 4, 2021

CLA Not Signed

@acao
Copy link
Member

acao commented Jun 16, 2021

thank you! @Sweetabix1 can you sign the CLA?

@Sweetabix1
Copy link
Contributor Author

thank you! @Sweetabix1 can you sign the CLA?

Hi @acao I signed the CLA as an individual contributor but it's still showing for me as 'not covered', is the 'corporate contributor' required?

nice work with the project also 🙂

@acao
Copy link
Member

acao commented Jun 17, 2021

@Sweetabix1 :)!!

Pinging @brianwarner, do you know why the CLA bot is not authorizing folks who sign as individual contributors?

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #1883 (a81ed75) into main (2d91916) will increase coverage by 0.70%.
The diff coverage is 61.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1883      +/-   ##
==========================================
+ Coverage   65.70%   66.40%   +0.70%     
==========================================
  Files          85       86       +1     
  Lines        5106     5153      +47     
  Branches     1631     1643      +12     
==========================================
+ Hits         3355     3422      +67     
+ Misses       1747     1727      -20     
  Partials        4        4              
Impacted Files Coverage Δ
...ackages/graphiql-toolkit/src/create-fetcher/lib.ts 51.78% <27.27%> (-7.79%) ⬇️
packages/graphiql/src/components/GraphiQL.tsx 58.34% <100.00%> (+0.83%) ⬆️
...hql-language-service-server/src/findGraphQLTags.ts 67.64% <100.00%> (+7.00%) ⬆️
...raphql-language-service-parser/src/onlineParser.ts 87.23% <0.00%> (-3.14%) ⬇️
...kages/graphql-language-service-parser/src/Rules.ts 96.80% <0.00%> (-0.97%) ⬇️
...iql/src/components/DocExplorer/MarkdownContent.tsx 100.00% <0.00%> (ø)
packages/graphiql/src/utility/HistoryStore.ts 62.26% <0.00%> (ø)
...raphql-language-service-server/src/GraphQLCache.ts 52.25% <0.00%> (+0.60%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9442058...a81ed75. Read the comment docs.

@brianwarner
Copy link
Contributor

Thanks @Sweetabix1, can you try to sign as an individual again? I see a record and I think it's yours, but the name is missing.

@Sweetabix1
Copy link
Contributor Author

hi @brianwarner, no problem I did it again just now, it should be named & signed in the appropriate places, did it work?

@acao
Copy link
Member

acao commented Jul 17, 2021

@Sweetabix1 not sure why it's still not working? @brianwarner do you know perhaps?

@Sweetabix1
Copy link
Contributor Author

@Sweetabix1 not sure why it's still not working? @brianwarner do you know perhaps?

I signed it again just now in case that one might show up 🙂

@acao
Copy link
Member

acao commented Aug 23, 2021

@Sweetabix1 would love to merge this soon! can you add a changeset as per the comment? also, perhaps you authorized the CLA bot using a different github account than the one you used to create this PR?

@acao
Copy link
Member

acao commented Sep 3, 2021

@Sweetabix1 ok I've now added the changeset file, and will merge as soon as the tests pass. Sorry about the CLA bot issues!

@acao acao added the graphiql label Oct 13, 2021
@acao acao merged commit afaa36c into graphql:main Oct 29, 2021
@github-actions github-actions bot mentioned this pull request Oct 29, 2021
@acao
Copy link
Member

acao commented Oct 29, 2021

thanks for your help on this @Sweetabix1 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants