Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove aniso8601, mock, iso8601 #1548

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented May 15, 2024

Python 3.7 added fromisoformat functionality, so we can remove aniso8601. There are test cases for it, and all are passing..

Removing mock, because the documentation states below, so we don't need it.

mock is now part of the Python standard library, available as [unittest.mock (https://docs.python.org/dev/library/unittest.mock.html) in Python 3.3 onwards.

@dulmandakh
Copy link
Contributor Author

@syrusakbary please review and merge.

Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (5fb7b54) to head (dedb1f0).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
+ Coverage   96.01%   96.11%   +0.10%     
==========================================
  Files          51       51              
  Lines        1755     1751       -4     
==========================================
- Hits         1685     1683       -2     
+ Misses         70       68       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dulmandakh dulmandakh changed the title remove aniso8601 remove aniso8601, mock, iso8601 May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant