Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test client is updated to be asyncio and not promises #1297

Closed
wants to merge 4 commits into from
Closed

fix: test client is updated to be asyncio and not promises #1297

wants to merge 4 commits into from

Conversation

wakemaster39
Copy link

resolves #1296

erikwrede
erikwrede requested changes Jul 27, 2022
View reviewed changes
Copy link
Member

@erikwrede erikwrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry for the late reply. Could you please add a test case for execute_async to maintain code coverage?

@mike-roberts-healx mike-roberts-healx mentioned this pull request Nov 16, 2022
Merged
@erikwrede
Copy link
Member

Superseded by #1476 which has been merged. Thanks for getting this started!

@erikwrede erikwrede closed this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikwrede erikwrede erikwrede requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test Client is still promise based
2 participants
@wakemaster39 @erikwrede