Remove unnecessary dependency on 'promise' library #1476
Conversation
Codecov ReportBase: 95.88% // Head: 95.93% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1476 +/- ##
==========================================
+ Coverage 95.88% 95.93% +0.05%
==========================================
Files 50 50
Lines 1724 1724
==========================================
+ Hits 1653 1654 +1
+ Misses 71 70 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
erikwrede
force-pushed
the
rm-promise-dependency
branch
from
f2e2db5
to
bfd0b34
Compare
Previously, installing graphene and trying to do `from graphene.test import Client` as recommended in the docs caused an `ImportError`, as the 'promise' library is imported but only listed as a requirement in the 'test' section of the setup.py file.
erikwrede
force-pushed
the
rm-promise-dependency
branch
from
bfd0b34
to
09d65cb
Compare
|
My enter key was stuck on merge, so here's a more complete merge Message for future reference: Thanks for getting this done 🙂 |
Previously, installing graphene and trying to do
from graphene.test import Clientas recommended in the docs caused anImportError, as the 'promise' library is imported but only listed as a requirement in the 'test' section of the setup.py file.Based on #1297 which appears to be inactive. Fixes #1296.