⬆️ Expand aiohttp version range #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new version of aiohttp has been released, with [an important fix preventing header injection](aio-libs/aiohttp#4818). I looked through the aiohttp changelog and wasn't able to find any breaking changes, so I believe it should be safe to use with gql.
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 1802 1802
=========================================
Hits 1802 1802 Continue to review full report at Codecov.
|
leszekhanusz
approved these changes
Dec 6, 2021
|
Thanks for your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new version of aiohttp has been released, with an important fix preventing header injection. I looked through the aiohttp changelog and wasn't able to find any breaking changes, so I believe it should be safe to use with gql.
All of the offline tests passed locally with aiohttp 3.8.1 installed 🙂
Thanks for your work on gql! 😄