Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dynamic output property #205

Merged
merged 9 commits into from
Aug 26, 2019
Merged

fix: dynamic output property #205

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6055bf9
fix: adjust dynamic for nexus-prisma
jasonkuhrt Aug 23, 2019
fc5ab57
explain misnomer
jasonkuhrt Aug 24, 2019
ec8542d
integrate feedback
jasonkuhrt Aug 25, 2019
2b7e67f
Revert "integrate feedback"
jasonkuhrt Aug 25, 2019
86bd4e9
Revert "explain misnomer"
jasonkuhrt Aug 25, 2019
5cebead
Revert "fix: adjust dynamic for nexus-prisma"
jasonkuhrt Aug 25, 2019
b147abd
fix: dynamic output property
jasonkuhrt Aug 25, 2019
836b08e
undo input oriented change
jasonkuhrt Aug 25, 2019
fe20d22
export dynamic output property
jasonkuhrt Aug 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 11 additions & 9 deletions src/builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1149,15 +1149,17 @@ export class SchemaBuilder {
return this.addDynamicScalar(methodName, val, block);
}
// @ts-ignore
block[methodName] = (...args: any[]) => {
const config = isList ? [args[0], { list: isList, ...args[1] }] : args;
jasonkuhrt marked this conversation as resolved.
Show resolved Hide resolved
return val.value.factory({
args: config,
typeDef: block,
builder: this,
typeName: block.typeName,
});
};
Object.defineProperty(block, methodName, {
jasonkuhrt marked this conversation as resolved.
Show resolved Hide resolved
get() {
return val.value.factory({
args: [],
typeDef: block,
builder: this,
typeName: block.typeName,
})
},
enumerable: true,
})
});
}

Expand Down