Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dashes from Automatic-Module-Name #79

Merged
merged 1 commit into from Sep 22, 2022

Conversation

dondonz
Copy link
Member

@dondonz dondonz commented Sep 22, 2022

Thanks to everyone who reported the issue. The invalid dashes in the Automatic-Module-Name was a problem.

This name aligns with the Automatic-Module-Name com.graphqljava for the GraphQL Java jar.

#70
#60
#65

@asinbow
Copy link

asinbow commented Nov 2, 2022

Thanks for the fix! As I know it impacted 19.x and 18.x, it won't be better if we could release new version for both 19.x and 18.x.

@dondonz dondonz added this to the 19.1 milestone Nov 11, 2022
@dondonz dondonz deleted the automatic-module-name-fix branch November 11, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants