Support .NET 7.0

[zcsizmadia]

.NET 7.0 just went RC (rc.1) and expected to be officially released in mid November 2022. This PR should be merged once .NET 7.0 is released on November, however in the meantime the build process can be validated.

Note:
Before merging include-prerelease: true lines should be removed from the github workflow actions/setup-dotnet@v2 actions.

[zcsizmadia]

.NET Core 3.1 will go EOL mid December 2022 and .NET 5.0 is already EOL (https://dotnet.microsoft.com/en-us/download/dotnet)

Those targets could be removed as well when NET 7 is released. Supporting those EOL frameworks will be ok using the netstandard2.x targets.

[Shane32]

.NET Core 3.1 will go EOL mid December 2022 and .NET 5.0 is already EOL (https://dotnet.microsoft.com/en-us/download/dotnet)

Those targets could be removed as well when NET 7 is released. Supporting those EOL frameworks will be ok using the netstandard2.x targets.

GraphQL.NET only targets .NET Standard 2.0, .NET Standard 2.1 and .NET 6, as there are no ifdefs for other target frameworks. System.Text.Json includes a target for .NET Core 3.1 because System.Text.Json is included with .NET Core 3.0+. As such, the dependency can be eliminated.

At present I see no reason to change the targeted frameworks. I feel that .NET Core 3.1 is especially important because not only it is a LTS release, a number of the packages developed at that time are cross-platform compatible with .NET Framework -- for example, Entity Framework Core 3.1.x. While perhaps these applications can all run on .NET 6, when using the 3.1.x components of that time, it may be more likely that applications written for .NET Core 3.1 designed to be cross compatible with .NET Framework may not yet be upgraded to .NET 6. There is a similar situation that exists with .NET Core 2.1 for web applications -- hence why GraphQL.NET Server 7.x now supports .NET Framework and .NET Core 2.1 web applications. (Note that in that situation, there is official support from Microsoft for ASP.NET Core 2.1.x when run on supported editions of .NET Framework.)

I would have little argument against removing .NET 5 code -- it was never a LTS release and is more of a preview of .NET 6, just like .NET Core 3.0 was compared to .NET Core 3.1. But yet, there is no reason to at this time.

If and when it becomes troublesome to perform development/testing for older frameworks (e.g. trying to develop/test .NET Framework 4.5 applications today), we will likely drop those frameworks from the test suite and/or libraries at that time.

Thanks for the PR! As you suggest, we likely will not merge the PR until .NET 7.0 is released.

[sungam3r]

Those targets could be removed as well when NET 7 is released. Supporting those EOL frameworks will be ok using the netstandard2.x targets.

Well, I'm not so positive to quickly remove support for "old" TFMs especially if this support is given at low price.

[sungam3r]

I would have little argument against removing .NET 5 code -- it was never a LTS release and is more of a preview of .NET 6, just like .NET Core 3.0 was compared to .NET Core 3.1. But yet, there is no reason to at this time.

If and when it becomes troublesome to perform development/testing for older frameworks (e.g. trying to develop/test .NET Framework 4.5 applications today), we will likely drop those frameworks from the test suite and/or libraries at that time.

Thanks for the PR! As you suggest, we likely will not merge the PR until .NET 7.0 is released.

Agree. Let's merge ASAP after NET7 release.

[sungam3r]

Suggested change

	- name: Setup .NET 7.0 SDK
	- name: Setup .NET SDK

[sungam3r]

Suggested change

	- name: Setup .NET 7.0 SDK
	- name: Setup .NET SDK

[sungam3r]

Suggested change

	- name: Setup .NET 7.0 SDK
	- name: Setup .NET SDK

[sungam3r]

I'm fine to merge this one after resolving conflicts and .NET7 release.

[zcsizmadia]

@sungam3r Merged master into the PR:

1. Using EOL SDKs, the build will generate several EOL warnings. As of now it is only 5.0, however 3.1 goes EOL soon, so that will do the same. Added <CheckEolTargetFramework>false</CheckEolTargetFramework> to Directory.build.props to disable that warning. (EOL SDKs are used only for tests and benchmarks)
2. dotnet-quality: preview should be removed from the github workflow yml files before merging this PR. NET 7 is expected to be released later next week. As soon as it is out, I will remove it and do a final build/test without allowing preview SDK.

[sungam3r]

CheckEolTargetFramework is fine, we use it in the server project as well.

[zcsizmadia]

@Shane32

1. Removed the comments for CheckEolTargetFramework
2. Removed the ApolloTrace AddTicks fix. The tests in this PR will fail until Fix accuracy of Apollo trace endTime property #3384 is not merged.

[sungam3r]

I see growing mails from dependabot updating different stuff to 7.0.0 😮 but I don't see 7.0.0 release on MS site yet.

[codecov-commenter]

Codecov Report

Merging #3329 (01c4bf0) into master (06d7bd7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3329   +/-   ##
=======================================
  Coverage   83.84%   83.84%           
=======================================
  Files         376      376           
  Lines       16274    16274           
  Branches     2610     2613    +3     
=======================================
  Hits        13645    13645           
  Misses       2011     2011           
  Partials      618      618           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[zcsizmadia]

NET 7 was released today. Merged master into the PR branch and removed the dotnet-quality=preview lines from the github workflows.

[Shane32]

Visual Studio 17.4 hasn't been released yet. Probably it will be within a day or so and then we can merge this.

[sungam3r]

I have run VS installer just now - 2.4 Gb update for 17.4 :)

[sungam3r]

Successful build on my machine except broken localization in console