Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UnionGraphType to support CLR references #3320

Merged
merged 2 commits into from Sep 16, 2022

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Sep 6, 2022

Fixes #3319

@Shane32 Shane32 self-assigned this Sep 6, 2022
@github-actions github-actions bot added the test Pull request that adds new or changes existing tests label Sep 6, 2022
@Shane32 Shane32 added bugfix Pull request that fixes a bug and removed test Pull request that adds new or changes existing tests labels Sep 6, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3320 (fe6c1f1) into master (80b966e) will increase coverage by 0.04%.
The diff coverage is 38.46%.

@@            Coverage Diff             @@
##           master    #3320      +/-   ##
==========================================
+ Coverage   84.04%   84.08%   +0.04%     
==========================================
  Files         376      376              
  Lines       16179    16188       +9     
  Branches     2600     2602       +2     
==========================================
+ Hits        13597    13612      +15     
+ Misses       1964     1958       -6     
  Partials      618      618              
Impacted Files Coverage Δ
src/GraphQL/Types/GraphQLTypeReference.cs 39.28% <0.00%> (-2.39%) ⬇️
src/GraphQL/Types/Collections/SchemaTypes.cs 88.30% <71.42%> (-0.08%) ⬇️
...aphQL/Types/Composite/ObjectGraphTypeExtensions.cs 41.66% <0.00%> (+41.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Shane32 Shane32 added this to the 7.1 milestone Sep 13, 2022
@Shane32
Copy link
Member Author

Shane32 commented Sep 13, 2022

Will merge soon if there are no comments on this.

@Shane32 Shane32 merged commit 3da92de into master Sep 16, 2022
@Shane32 Shane32 deleted the uniongraphtype_support_references branch September 16, 2022 14:33
@sungam3r
Copy link
Member

reviewed

Kent-Chen-Conning added a commit to Conning/graphql-dotnet that referenced this pull request Oct 28, 2022
…TRAC-6694-upgrade-graphql-dotnet-server-to-7.1

* commit '13da37d7c0649cc6186714a6671272af49f06d85': (1255 commits)
  Add type integrity check when existing types are found (graphql-dotnet#3332)
  Switch to Nullability.Source (graphql-dotnet#3314)
  Add missing authorization extensions from field and connection builders (graphql-dotnet#3324)
  Prevent using graphtype as model (graphql-dotnet#3316)
  Remove init-only properties from pre-.NET 5 targets (graphql-dotnet#3323)
  Update UnionGraphType to support CLR references (graphql-dotnet#3320)
  Bump BenchmarkDotNet from 0.13.1 to 0.13.2 (graphql-dotnet#3313)
  Bump Microsoft.NET.Test.Sdk from 17.3.0 to 17.3.1 (graphql-dotnet#3311)
  Fix InputFieldsAndArgumentsOfCorrectLength validation rule (graphql-dotnet#3307)
  Bump Shouldly from 4.0.3 to 4.1.0 (graphql-dotnet#3304)
  Add test (graphql-dotnet#3302)
  !(a is T) -> a is not T (graphql-dotnet#3300)
  User not duplicated in context (graphql-dotnet#3298)
  Bump deps (graphql-dotnet#3295)
  Restore `Field<TGraphType>()` method (graphql-dotnet#3294)
  Include v7 migration document link in readme (graphql-dotnet#3290)
  Bump GraphQL-Parser to 8.1.0 (graphql-dotnet#3289)
  Migration notes updates (graphql-dotnet#3287)
  Simplify configuration (graphql-dotnet#3286)
  Introduce ErrorInfoProviderOptions.ExposeExceptionDetailsMode (graphql-dotnet#3276)
  ...

# Conflicts:
#	docs/package.json
#	src/GraphQL/GraphQL.csproj
#	src/GraphQL/Types/GraphTypesLookup.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use UnionGraphType with auto graph types
3 participants