Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unconstrained tokio budget for run_subgraph. #2359

Merged
merged 3 commits into from
Apr 8, 2021
Merged

Conversation

leoyvens
Copy link
Collaborator

@leoyvens leoyvens commented Apr 8, 2021

This PR:

  1. Reverts Go back to running subgraphs with spawn_blocking #2357, that was being done in lack of a better idea, and this is a better idea.
  2. Updates futures 0.1.x from 0.1.30 to 0.1.31, which fixes a potential deadlock in FuturesUnordered when combined with the tokio cooperative scheduler, we use FuturesUnordered in the block stream so this may be affecting us.
  3. While 2 might be sufficient to fix the deadlock, to be sure this disables cooperative scheduling for run_subgraph. It's being run in its own thread so there is nothing to gain from cooperative scheduling anyways.

@leoyvens leoyvens merged commit dc109f5 into master Apr 8, 2021
@leoyvens leoyvens deleted the leo/tokio-uncoop branch April 8, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants