Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): cleaner GraphQL schema snapshots #533

Merged
merged 17 commits into from Oct 15, 2019
Merged

chore(tests): cleaner GraphQL schema snapshots #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1c3674c
Cleaner snapshots for postgraphile-core tests
singingwolfboy Oct 8, 2019
bf9a5cf
Cleaner snapshots for pg-pubsub tests
singingwolfboy Oct 8, 2019
95ae103
Cleaner snapshots for graphile-utils tests
singingwolfboy Oct 8, 2019
223d4c2
Cleaner snapshots for graphile-build tests
singingwolfboy Oct 8, 2019
d856506
One more test assertion
singingwolfboy Oct 12, 2019
76edbda
Move GraphQLSchema snapshot serializer to separate package
singingwolfboy Oct 12, 2019
86234ed
sort schema
singingwolfboy Oct 12, 2019
c09b7f9
remove printSchemaOrdered
singingwolfboy Oct 12, 2019
52e1f76
remove unneeded line
singingwolfboy Oct 12, 2019
70fdb15
yarn-deduplicate
singingwolfboy Oct 12, 2019
65e947a
Add README and test for jest-serializer-graphql-schema
singingwolfboy Oct 13, 2019
cec6217
Do not sort schemas by default when serializing
singingwolfboy Oct 13, 2019
e1aff3d
jest-serializer-graphql-schema: version and files
singingwolfboy Oct 13, 2019
66700c6
more flexible getSchema function
singingwolfboy Oct 13, 2019
414a6ef
ts-jest
singingwolfboy Oct 13, 2019
e887133
more minimal changes to yarn.lock
singingwolfboy Oct 13, 2019
d61fd9e
Merge branch 'master' into clearer-schema-snapshots
benjie Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/graphile-build-pg/package.json
View file
Open in desktop
Expand Up @@ -58,6 +58,9 @@
"jest": "^24.8.0"
},
"jest": {
"snapshotSerializers": [
"jest-serializer-graphql-schema"
],
"transform": {
"^.+\\.jsx?$": "../../.jest-wrapper.js"
},
Expand Down
22 changes: 11 additions & 11 deletions packages/graphile-build/__tests__/__snapshots__/emptyMutation.test.js.snap
View file
Open in desktop
@@ -1,32 +1,32 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`generates empty schema (with no Mutation type) 1`] = `
"\\"\\"\\"An object with a globally unique \`ID\`.\\"\\"\\"
"""An object with a globally unique \`ID\`."""
interface Node {
\\"\\"\\"
"""
A globally unique identifier. Can be used in various places throughout the system to identify this single value.
\\"\\"\\"
"""
id: ID!
}

\\"\\"\\"The root query type which gives access points into the data universe.\\"\\"\\"
"""The root query type which gives access points into the data universe."""
type Query implements Node {
\\"\\"\\"
"""
Exposes the root query type nested one level down. This is helpful for Relay 1
which can only query top level fields if they are in a particular form.
\\"\\"\\"
"""
query: Query!

\\"\\"\\"
"""
The root query type must be a \`Node\` to work well with Relay 1 mutations. This just resolves to \`query\`.
\\"\\"\\"
"""
id: ID!

\\"\\"\\"Fetches an object given its globally unique \`ID\`.\\"\\"\\"
"""Fetches an object given its globally unique \`ID\`."""
node(
\\"\\"\\"The globally unique \`ID\`.\\"\\"\\"
"""The globally unique \`ID\`."""
id: ID!
): Node
}
"

`;
30 changes: 15 additions & 15 deletions packages/graphile-build/__tests__/__snapshots__/enum.test.js.snap
View file
Open in desktop
@@ -1,40 +1,40 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`generated schema 1`] = `
"enum MyEnum {
ONE @deprecated(reason: \\"We no longer support numbers smaller than PI\\")
TWO @deprecated(reason: \\"We no longer support numbers smaller than PI\\")
THREE @deprecated(reason: \\"We no longer support numbers smaller than PI\\")
enum MyEnum {
ONE @deprecated(reason: "We no longer support numbers smaller than PI")
TWO @deprecated(reason: "We no longer support numbers smaller than PI")
singingwolfboy marked this conversation as resolved.
Show resolved Hide resolved
THREE @deprecated(reason: "We no longer support numbers smaller than PI")
FOUR
}

\\"\\"\\"An object with a globally unique \`ID\`.\\"\\"\\"
"""An object with a globally unique \`ID\`."""
interface Node {
\\"\\"\\"
"""
A globally unique identifier. Can be used in various places throughout the system to identify this single value.
\\"\\"\\"
"""
id: ID!
}

\\"\\"\\"The root query type which gives access points into the data universe.\\"\\"\\"
"""The root query type which gives access points into the data universe."""
type Query implements Node {
\\"\\"\\"
"""
Exposes the root query type nested one level down. This is helpful for Relay 1
which can only query top level fields if they are in a particular form.
\\"\\"\\"
"""
query: Query!

\\"\\"\\"
"""
The root query type must be a \`Node\` to work well with Relay 1 mutations. This just resolves to \`query\`.
\\"\\"\\"
"""
id: ID!

\\"\\"\\"Fetches an object given its globally unique \`ID\`.\\"\\"\\"
"""Fetches an object given its globally unique \`ID\`."""
node(
\\"\\"\\"The globally unique \`ID\`.\\"\\"\\"
"""The globally unique \`ID\`."""
id: ID!
): Node
enum: MyEnum
}
"

`;
24 changes: 12 additions & 12 deletions packages/graphile-build/__tests__/__snapshots__/fieldData.test.js.snap
View file
Open in desktop
Expand Up @@ -36,7 +36,7 @@ Object {
`;

exports[`generated schema 1`] = `
"\\"\\"\\"A location in a connection that can be used for resuming pagination.\\"\\"\\"
"""A location in a connection that can be used for resuming pagination."""
scalar Cursor

type Dummy {
Expand All @@ -62,35 +62,35 @@ type DummyEdge {
node: Dummy
}

\\"\\"\\"An object with a globally unique \`ID\`.\\"\\"\\"
"""An object with a globally unique \`ID\`."""
interface Node {
\\"\\"\\"
"""
A globally unique identifier. Can be used in various places throughout the system to identify this single value.
\\"\\"\\"
"""
id: ID!
}

\\"\\"\\"The root query type which gives access points into the data universe.\\"\\"\\"
"""The root query type which gives access points into the data universe."""
type Query implements Node {
\\"\\"\\"
"""
Exposes the root query type nested one level down. This is helpful for Relay 1
which can only query top level fields if they are in a particular form.
\\"\\"\\"
"""
query: Query!

\\"\\"\\"
"""
The root query type must be a \`Node\` to work well with Relay 1 mutations. This just resolves to \`query\`.
\\"\\"\\"
"""
id: ID!

\\"\\"\\"Fetches an object given its globally unique \`ID\`.\\"\\"\\"
"""Fetches an object given its globally unique \`ID\`."""
node(
\\"\\"\\"The globally unique \`ID\`.\\"\\"\\"
"""The globally unique \`ID\`."""
id: ID!
): Node
dummyConnection(first: Int, after: Cursor, sortBy: DummyConnectionSortBy): DummyConnection
}
"

`;

exports[`no arguments 1`] = `
Expand Down
48 changes: 24 additions & 24 deletions packages/graphile-build/__tests__/__snapshots__/watch.test.js.snap
View file
Open in desktop
@@ -1,73 +1,73 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`generated schema n = 0, n = 3 1`] = `
"type Dummy0 {
type Dummy0 {
n: Int!
}

\\"\\"\\"An object with a globally unique \`ID\`.\\"\\"\\"
"""An object with a globally unique \`ID\`."""
interface Node {
\\"\\"\\"
"""
A globally unique identifier. Can be used in various places throughout the system to identify this single value.
\\"\\"\\"
"""
id: ID!
}

\\"\\"\\"The root query type which gives access points into the data universe.\\"\\"\\"
"""The root query type which gives access points into the data universe."""
type Query implements Node {
\\"\\"\\"
"""
Exposes the root query type nested one level down. This is helpful for Relay 1
which can only query top level fields if they are in a particular form.
\\"\\"\\"
"""
query: Query!

\\"\\"\\"
"""
The root query type must be a \`Node\` to work well with Relay 1 mutations. This just resolves to \`query\`.
\\"\\"\\"
"""
id: ID!

\\"\\"\\"Fetches an object given its globally unique \`ID\`.\\"\\"\\"
"""Fetches an object given its globally unique \`ID\`."""
node(
\\"\\"\\"The globally unique \`ID\`.\\"\\"\\"
"""The globally unique \`ID\`."""
id: ID!
): Node
dummy: Dummy0
}
"

`;

exports[`generated schema n = 0, n = 3 2`] = `
"type Dummy3 {
type Dummy3 {
n: Int!
}

\\"\\"\\"An object with a globally unique \`ID\`.\\"\\"\\"
"""An object with a globally unique \`ID\`."""
interface Node {
\\"\\"\\"
"""
A globally unique identifier. Can be used in various places throughout the system to identify this single value.
\\"\\"\\"
"""
id: ID!
}

\\"\\"\\"The root query type which gives access points into the data universe.\\"\\"\\"
"""The root query type which gives access points into the data universe."""
type Query implements Node {
\\"\\"\\"
"""
Exposes the root query type nested one level down. This is helpful for Relay 1
which can only query top level fields if they are in a particular form.
\\"\\"\\"
"""
query: Query!

\\"\\"\\"
"""
The root query type must be a \`Node\` to work well with Relay 1 mutations. This just resolves to \`query\`.
\\"\\"\\"
"""
id: ID!

\\"\\"\\"Fetches an object given its globally unique \`ID\`.\\"\\"\\"
"""Fetches an object given its globally unique \`ID\`."""
node(
\\"\\"\\"The globally unique \`ID\`.\\"\\"\\"
"""The globally unique \`ID\`."""
id: ID!
): Node
dummy: Dummy3
}
"

`;
3 changes: 1 addition & 2 deletions packages/graphile-build/__tests__/emptyMutation.test.js
View file
Open in desktop
@@ -1,7 +1,6 @@
const { printSchema } = require("graphql/utilities");
const { buildSchema, defaultPlugins } = require("../");

test("generates empty schema (with no Mutation type)", async () => {
const schema = await buildSchema([...defaultPlugins]);
expect(printSchema(schema)).toMatchSnapshot();
expect(schema).toMatchSnapshot();
});
3 changes: 1 addition & 2 deletions packages/graphile-build/__tests__/enum.test.js
View file
Open in desktop
@@ -1,5 +1,4 @@
const { GraphQLEnumType } = require("graphql");
const { printSchema } = require("graphql/utilities");
const { buildSchema, defaultPlugins } = require("../");

function EnumPlugin(builder) {
Expand Down Expand Up @@ -60,5 +59,5 @@ function EnumPlugin(builder) {

test("generated schema", async () => {
const schema = await buildSchema([...defaultPlugins, EnumPlugin]);
expect(printSchema(schema)).toMatchSnapshot();
expect(schema).toMatchSnapshot();
});
3 changes: 1 addition & 2 deletions packages/graphile-build/__tests__/fieldData.test.js
View file
Open in desktop
Expand Up @@ -7,7 +7,6 @@ const {
GraphQLNonNull,
GraphQLList,
} = require("graphql");
const { printSchema } = require("graphql/utilities");
const { buildSchema, defaultPlugins } = require("../");

const base64 = str => Buffer.from(String(str)).toString("base64");
Expand Down Expand Up @@ -291,7 +290,7 @@ const DummyConnectionPlugin = async builder => {

test("generated schema", async () => {
const schema = await buildSchema([...defaultPlugins, DummyConnectionPlugin]);
expect(printSchema(schema)).toMatchSnapshot();
expect(schema).toMatchSnapshot();
});

test("no arguments", async () => {
Expand Down
6 changes: 3 additions & 3 deletions packages/graphile-build/__tests__/watch.test.js
View file
Open in desktop
Expand Up @@ -3,8 +3,8 @@ const {
GraphQLObjectType,
GraphQLInt,
GraphQLNonNull,
printSchema,
} = require("graphql");
const { printSchema } = require("graphql/utilities");
const {
getBuilder,
defaultPlugins: allDefaultPlugins,
Expand Down Expand Up @@ -91,12 +91,12 @@ test("generated schema n = 0, n = 3", async () => {
...defaultPlugins,
makePluginEtc(0).plugin,
])).buildSchema();
expect(printSchema(schema0)).toMatchSnapshot();
expect(schema0).toMatchSnapshot();
const schema3 = (await getBuilder([
...defaultPlugins,
makePluginEtc(3).plugin,
])).buildSchema();
expect(printSchema(schema3)).toMatchSnapshot();
expect(schema3).toMatchSnapshot();
});

test("schema is cached if no watcher fires", async () => {
Expand Down
3 changes: 3 additions & 0 deletions packages/graphile-build/package.json
View file
Open in desktop
Expand Up @@ -53,6 +53,9 @@
"graphql": ">=0.9 <0.14 || ^14.0.2"
},
"jest": {
"snapshotSerializers": [
"jest-serializer-graphql-schema"
],
"transform": {
"^.+\\.jsx?$": "../../.jest-wrapper.js"
},
Expand Down