Add support to exclude packages/paths #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only works for checks that support exclusions (`errcheck`) - Other checks silently ignore the setting, since they don't support it There might be some fancy magic we could do with, say, `find -type f -iname '*.go' ...` instead of `./...`, but even that only works for checks that support lists of files rather than just a single package name/path. Or, well, we'd have to do some major refactoring on the checks that don't support file lists. And probably all the checks, at that, since command lines have a length limit, so large projects would break the logic with a full listing of all non-excluded files. Anyway, this is the best I can do at the moment without addressing the problems above. Addresses grandcolline#11. Enjoy!
danhunsaker
force-pushed
the
feature/excludes
branch
from
057fa63
to
bd89611
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
errcheck)There might be some fancy magic we could do with, say,
find -type f -iname '*.go' ...instead of./..., but even that only works for checks that support lists of files rather than just a single package name/path. Or, well, we'd have to do some major refactoring on the checks that don't support file lists. And probably all the checks, at that, since command lines have a length limit, so large projects would break the logic with a full listing of all non-excluded files.Anyway, this is the best I can do at the moment without addressing the problems above. Addresses #11.
Enjoy!