Fixed Grails issue #12460 #257
Conversation
Use BeanClassLoaderAware, no need to set classLoader property declaratively.
|
|
|
Shouldn't |
|
@darxriggs you're right, see another PR #258 |
| @@ -202,7 +202,7 @@ class GroovyPagesGrailsPlugin extends Plugin { | |||
|
|
|||
| // Setup the main templateEngine used to render GSPs | |||
| groovyPagesTemplateEngine(GroovyPagesTemplateEngine) { bean -> | |||
| classLoader = ref("classLoader") | |||
| bean.lazyInit = true | |||
There was a problem hiding this comment.
Is this change of lazyInit related to the issue?
There was a problem hiding this comment.
no. gspTagLibraryLookup is very time consuming, it is lazy, so I add too.
There was a problem hiding this comment.
Based on my test, the lazy-init doesn't have a noticeable effect, I can remove it currently.
There was a problem hiding this comment.
I found a method to optimize gspTagLibraryLookup, this will greatly reduce initialization time.
| @@ -201,14 +201,6 @@ public void setJspTagLibraryResolver(TagLibraryResolver jspTagLibraryResolver) { | |||
| this.jspTagLibraryResolver = jspTagLibraryResolver; | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Is there any specific reason to remove the setter?
There was a problem hiding this comment.
The discussion started here in spring-framework and this answer should shed some light on this.
|
@puneetbehl will this be merged to 5.2.x? |
Use BeanClassLoaderAware, no need to set classLoader property declaratively.
See grails/grails-core#12460