Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #110 issue, ValidationException not thrown when Domain has embedded object #111

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

aulea
Copy link
Contributor

@aulea aulea commented Dec 3, 2018

In separate commits fixed first also failing tests:

  • wrong Rollback and Transaction annotations, will refer now to gorm package
  • running all tests together, then there was data corruption - used unique H2 mem database name

@CLAassistant
Copy link

CLAassistant commented Dec 3, 2018

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ aulea
❌ Alar Aule


Alar Aule seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Alar Aule and others added 3 commits December 5, 2018 09:56
# Conflicts:
#	grails-datastore-gorm-hibernate5/src/test/groovy/grails/gorm/tests/UniqueConstraintSpec.groovy
#	grails-datastore-gorm-hibernate5/src/test/groovy/grails/gorm/tests/jpa/SimpleJpaEntitySpec.groovy
# Conflicts:
#	grails-datastore-gorm-hibernate5/src/test/groovy/org/grails/orm/hibernate/connections/DataSourceConnectionSourceFactorySpec.groovy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants