Adds jsx-no-ampersands

[niculistana]

Purpose

Adds lint rule check JSXExpressionContainer for ampersands and report a message.

Testing locally

1. Installing

npm install --save -D ~/path/to/parent/eslint-plugin-grailed

or add the following to your package.json and run npm install

"devDependencies": {
    "eslint-plugin-grailed": "file:~/path/to/parent/eslint-plugin-grailed"
}

2. Modify .eslintrc

{
  "plugins": [
    "grailed"
  ],
  "rules": {
    "grailed/jsx-no-ampersands": "warn"
  }
}

const TestComponent = () => {
     return <div>{true && <p>Show me the warning</p>}</div>
}

Links

• Use ternaries rather than && in JSX
• eslint-plugin-react Draft PR

Demo

https://www.loom.com/share/66e0fa36825249df96be81f90ac734bb

NOTE In the demo we install our package locally, but when we decide to use this in our production code base we will reference the package to our Github repo directly.

[brianabaker]

OOO cool, it looks like adding jsx-embed-condition to eslint-plugin-react is a draft pull request, so we're making it happen earlier than they add it? Is that correct?

[GeneTheBean]

From the discussion being had on their PR it doesn't seem like they are moving forward with it, so we're adding it ourselves for or own use case

[brianabaker]

I tried to test this through
npm install --save -D ~/path/to/parent/eslint-plugin-grailed
and got
Could not install from "../../path/to/parent/eslint-plugin-grailed" as it does not contain a package.json file

[GeneTheBean]

I tried to test this through
npm install --save -D ~/path/to/parent/eslint-plugin-grailed
and got
Could not install from "../../path/to/parent/eslint-plugin-grailed" as it does not contain a package.json file

You have to clone this repo in another directory, and then from your grailed project you npm install referencing that directory

[brianabaker]

You have to clone this repo in another directory, and then from your grailed project you npm install referencing that directory

Ah ofc ty! I'll do that in a bit :)

[vanev]

Typo!