Pull in tar-rs fork to work around startup issue. #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tar-rs` has an issue where it won't overwrite files if they're stored as hard links in the tar. We install our asset `node_modules` with pnpm, which uses hard links to deduplicate content. This means `grafbase dev` will refuse to overwrite some existing files on startup. I've fixed this PRd it, this pulls the fix in the meantime.
obmarg
commented
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tar-rshas an issue where it won't overwrite files if they're stored as hard links in the tar. We install our assetnode_moduleswith pnpm, which uses hard links to deduplicate content. This meansgrafbase devwill refuse to overwrite some existing files on startup.I've fixed this and PRd it, this pulls the fix in the meantime.
Type of change