federated-graph: do not render empty types, empty enums in SDL #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
commented
May 15, 2024
| for (idx, object) in graph.objects.iter().enumerate() { | ||
| let object_name = &graph[object.name]; | ||
| let is_query_root = graph.root_operation_types.query == ObjectId(idx); | ||
|
|
||
| if let Some(description) = object.description { |
There was a problem hiding this comment.
The diff is not very readable from here, but it's just a bunch of code moving inside an if block.
obmarg
approved these changes
May 15, 2024
engine/crates/federated-graph/src/render_sdl/render_federated_sdl.rs
Outdated
Show resolved
Hide resolved
They are not valid GraphQL. It's better to render an empty string, so let's do that. closes GB-6715
tomhoule
force-pushed
the
gb-6715-empty-federated-graphs-still-have-invalid-schemas-in
branch
from
40835fc
to
9be13a6
Compare
tomhoule
deleted the
gb-6715-empty-federated-graphs-still-have-invalid-schemas-in
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are not valid GraphQL. It's better to render an empty string, so let's do that.
closes GB-6715