fix: allow users to extend federation types #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obmarg
force-pushed
the
obmarg-push-wqkqxunuvxnw
branch
from
94d52e7
to
1168011
Compare
I was helping Fredrik setup for a sales demo last week, and we ran into some problems with the fairly common pattern of extending types from another subgraph: ```graphql extend type Whatever @key(fields: "id") { id: String, someField: String @join(...) } ``` 1. It would complain that `id` didn't have a join or custom resolver on it. 2. It'd complain that `Whatever` didn't exist for extension. It's quite easy to work around this by removing the `extend` keyword, but we should probably be friendlier to users and just let them do this.
obmarg
force-pushed
the
obmarg-push-wqkqxunuvxnw
branch
from
1168011
to
6148999
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was helping Fredrik setup for a sales demo last week, and we ran into some problems with the fairly common pattern of extending types from another subgraph:
iddidn't have a join or custom resolver on it.Whateverdidn't exist for extension.It's quite easy to work around this by removing the
extendkeyword, but we should probably be friendlier to users and just let them do this.Fixes GB-6682
Fixes GB-6678