Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade indirect hc-install package #483

Merged
merged 2 commits into from May 12, 2022
Merged

Upgrade indirect hc-install package #483

merged 2 commits into from May 12, 2022

Conversation

inkel
Copy link
Contributor

@inkel inkel commented May 12, 2022

This package is responsible for installing Terraform to perform acceptance tests. Since the announcement of the HashiCorp Releases API 3 days ago our CI is broken.

After further inspection, I've found that this package was indeed the culprit, and that we need to upgrade the package to 0.3.2 after hashicorp/hc-install#57 got merged.

This package is responsible for installing Terraform to perform
acceptance tests. Since the announcement of the HashiCorp Releases API
[1] 3 days ago our CI is broken. After further inspection, I've found
that this package was indeed the culprit, and that we need to upgrade
the package to 0.3.2 after
hashicorp/hc-install#57 got merged.

1: https://www.hashicorp.com/blog/announcing-the-hashicorp-releases-api
@inkel inkel requested a review from a team as a code owner May 12, 2022 18:45
@inkel inkel self-assigned this May 12, 2022
Copy link

@mildwonkey mildwonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Version 1.46+ throws a bunch of errors that doesn't really stop this from working.
@inkel
Copy link
Contributor Author

inkel commented May 12, 2022

I've also pinned the linter to version 1.45 instead of the latest, we can always review that in another PR.

@inkel inkel merged commit f420c48 into master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants