Add message_thread_id for Telegram contact points #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
3 tasks
|
|
internal/resources/grafana/resource_alerting_contact_point_notifiers.go
Outdated
Show resolved
Hide resolved
| @@ -264,6 +264,7 @@ func TestAccContactPoint_notifiers(t *testing.T) { | |||
| resource.TestCheckResourceAttr("grafana_contact_point.receiver_types", "telegram.#", "1"), | |||
| resource.TestCheckResourceAttr("grafana_contact_point.receiver_types", "telegram.0.token", "token"), | |||
| resource.TestCheckResourceAttr("grafana_contact_point.receiver_types", "telegram.0.chat_id", "chat-id"), | |||
| resource.TestCheckResourceAttr("grafana_contact_point.receiver_types", "telegram.0.message_thread_id", "message-thread-id"), | |||
There was a problem hiding this comment.
hmm wondering why that passes. That's not the value in the test file
There was a problem hiding this comment.
Oh wait, it doesn't. Tests hadn't run 😄
spinillos
approved these changes
Jan 15, 2024
|
I synced my branch with upstream 👍 |
|
Can't really merge this until it's supported in Grafana unfortunately |
|
I think Grafana Alerting has supported the Telegram message_thread_id, I can observe it from the UI, so is this PR good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See prometheus/alertmanager#3638.