Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add prefix configuration option to azure and gcs storage #2386

Merged
merged 5 commits into from
Apr 28, 2023

Conversation

kousikmitra
Copy link
Contributor

@kousikmitra kousikmitra commented Apr 27, 2023

What this PR does:

Add a new configuration option prefix in azure and gcs storage, with this option the users can now store all traces in a sub path of a shared bucket or container.

Which issue(s) this PR fixes:
Fixes #2100

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving docs. Thank you for adding comments to the config doc.

Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if I'm more impressed that you fixed actual/expected in the s3 tests or you got CI to pass in one shot.

Thanks for the contribution!

@joe-elliott joe-elliott merged commit 8610f53 into grafana:main Apr 28, 2023
14 checks passed
@kousikmitra
Copy link
Contributor Author

:) happy to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to configure subpaths within S3 buckets
3 participants