Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure subpaths within S3 buckets #2100

Closed
mapno opened this issue Feb 10, 2023 · 8 comments · Fixed by #2362 or #2386
Closed

Allow to configure subpaths within S3 buckets #2100

mapno opened this issue Feb 10, 2023 · 8 comments · Fixed by #2362 or #2386
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mapno
Copy link
Member

mapno commented Feb 10, 2023

Is your feature request related to a problem? Please describe.

Tempo's S3 config does not support using specific folder within an S3/GCS/Azure bucket to use as its root folder. This doesn't allow cleanly sharing buckets with other apps.

Describe the solution you'd like

Tempo should add support for subpaths within S3/GCS/Azure buckets.

Describe alternatives you've considered

Bucket names with / are not allowed per S3's bucket naming rules.

Additional context

Similar issues in Mimir grafana/mimir#1682 and Loki grafana/loki#5889

@mapno mapno added enhancement New feature or request good first issue Good for newcomers labels Feb 10, 2023
@shrey
Copy link

shrey commented Feb 20, 2023

I'd like to take this issue up!

@WildCatFish
Copy link
Contributor

Hi, @shrey is there any update on this issue?
We are having the same difficulty.

@kousikmitra
Copy link
Contributor

Hi, I would like to pick this up since there no reply from assigned user. Let me know if I can work on this.

One question,

  • Should this change only effect s3 and not gcs or azure?
  • I did a little dig up, and I hope this is the package tempodb/backend/s3 that will need necessary changes. Please let me know if I am on right track!

@joe-elliott
Copy link
Member

@kousikmitra We would love to have you give this a shot. Thanks for taking an interest!

Should this change only effect s3 and not gcs or azure?

It would be cool if we made it to all 3 backends at once. However, we appreciate any contribution and if s3 is all you can carve out some time to for, we understand.

I did a little dig up, and I hope this is the package tempodb/backend/s3 that will need necessary changes. Please let me know if I am on right track!

Yes, this change should be entirely doable in tempodb/backend/s3.

@kousikmitra
Copy link
Contributor

@kousikmitra We would love to have you give this a shot. Thanks for taking an interest!

Should this change only effect s3 and not gcs or azure?

It would be cool if we made it to all 3 backends at once. However, we appreciate any contribution and if s3 is all you can carve out some time to for, we understand.

@mapno I would love to make the change for other backends. If thats ok I will create another ticket and work on it.

@mapno
Copy link
Member Author

mapno commented Apr 27, 2023

Please, go ahead. Thanks for contributing to Tempo!

@kousikmitra
Copy link
Contributor

kousikmitra commented Apr 27, 2023

@mapno I have raised a PR with all changes. Can you please reopen the issue and update the description?

@mapno mapno reopened this May 5, 2023
@mapno
Copy link
Member Author

mapno commented May 5, 2023

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
5 participants