Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript: Enable strict mode #728

Merged
merged 3 commits into from May 13, 2024
Merged

Typescript: Enable strict mode #728

merged 3 commits into from May 13, 2024

Conversation

torkelo
Copy link
Member

@torkelo torkelo commented May 9, 2024

Should fix some of the errors that show up when yarn linking into main repo

@torkelo torkelo added the minor Increment the minor version when merged label May 9, 2024
@dprokop
Copy link
Member

dprokop commented May 10, 2024

hm, i see 94 errors when linking main and 94 errors when linking this branch. Are you sure this brings any improvement?

@Sergej-Vlasov
Copy link
Contributor

same result here 94 errors before and after. Strict mode can be annoying with extra errors but no additional errors here so would be for enabling strict mode

@torkelo
Copy link
Member Author

torkelo commented May 10, 2024

@dprokop well it fixes a few strict errors (see the ones fixed in PR) so it does something, not sure what else to enable

@torkelo
Copy link
Member Author

torkelo commented May 10, 2024

@dprokop is there any argument to not extend tsconfig (Which has the important strict: true option)

@torkelo
Copy link
Member Author

torkelo commented May 10, 2024

Strict mode can be annoying with extra errors but no additional errors here so would be for enabling strict mode

@Sergej-Vlasov not sure what your mean :)

@Sergej-Vlasov
Copy link
Contributor

Strict mode can be annoying with extra errors but no additional errors here so would be for enabling strict mode

@Sergej-Vlasov not sure what your mean :)

Sorry, meant to say that I support enabling strict mode in short 😅

@torkelo torkelo merged commit 1c676a7 into main May 13, 2024
3 checks passed
@torkelo torkelo deleted the enable-strict-typescript branch May 13, 2024 07:11
@grafanabot
Copy link
Contributor

🚀 PR was released in v4.20.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants