SceneGridLayout: Fix issue with grid taking 0 height #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Autosizer forces the consumer to have a parent with height or with flex layout.
This was causing the issue of having grid with height 0.
Approach
We can avoid that by not giving control to Autosizer and leaving the height to be the content.
We need the height from
Autosizerto know the space available to fill all panels for the autofit feature. However, we don't need to let the component manage it, so we can useuseMeasureto get the height.This approach can be improved to do the measurement only if the autofit is enabled.
TODO
It gets into an infinite loop. In case someone have time to take a look, feel free to take it