Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UrlSync: Started exploring improvements #551

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

torkelo
Copy link
Member

@torkelo torkelo commented Jan 30, 2024

Started exploring some url sync changes

  • Always include full url state in updateFromUrl not only changed values

Other things I want to fix

  • Support scene objects added later after initial url sync still being able to read state from URL
  • Fix timing issue where state change during updateFromUrl that triggers another url sync should break the current url sync so that the first url sync does not overwrite the state of a later update. Still not been able to create a unit test for this. Timing issue should be fixed by UrlSync: Fixes overwrite issue where later state change overwrites earlier change #555

Problem

  • some of these changes (esp the first) could create subtle new bugs (and potentially recursive update loops).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant