SceneFlexLayout: Add support for lazy-loading #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, this is something I wanted to point out in one of the feedback threads I posted. Given a multi-page, multi-tab, and a drill-down, the bundle went to ~ 500kb. But we don't need to load everything until the user accesses that area, so lazy loading is more than welcomed. |
dprokop
reviewed
Apr 27, 2023
| @@ -86,13 +91,14 @@ interface SceneFlexItemState extends SceneFlexItemPlacement, SceneObjectState { | |||
|
|
|||
| interface SceneFlexItemRenderProps<T> extends SceneComponentProps<T> { | |||
| parentDirection?: CSSProperties['flexDirection']; | |||
| isLazy?: boolean; | |||
| import { getQueryRunnerWithRandomWalkQuery, getEmbeddedSceneDefaults } from './utils'; | ||
| import { DebugItem } from './flexLayout'; | ||
|
|
||
| export function getLazyFlexDemo(defaults: SceneAppPageState) { |
There was a problem hiding this comment.
I couldn't get this demo show the lazy loading. So i've tried panel repeater demo with ridiculous 100 repeats and it seems like that demo doesn't render the timeseries viz anymore.
filehira
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving this as a draft because I have the feeling there are some edge-cases where this breaks down, but it's at least a start.